Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TZ Fix for event created on icloud app #5662

Merged
merged 2 commits into from
Nov 24, 2022
Merged

Conversation

alishaz-polymath
Copy link
Member

What does this PR do?

So, Apple being Apple decided to provide Timezone information in different places when an event is created on browser vs on the icloud native app. This PR adds the compatibility for adjusting TZ when the event is created on the app.

Fixes #5309

Environment: Staging(main branch)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

@alishaz-polymath alishaz-polymath requested review from emrysal and a team November 24, 2022 08:16
@alishaz-polymath alishaz-polymath self-assigned this Nov 24, 2022
@alishaz-polymath alishaz-polymath added the 🐛 bug Something isn't working label Nov 24, 2022
@vercel
Copy link

vercel bot commented Nov 24, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
cal ✅ Ready (Inspect) Visit Preview Nov 24, 2022 at 8:46AM (UTC)

Copy link
Member

@sean-brydon sean-brydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :) Pesky apple

@PeerRich PeerRich merged commit 7df04c1 into main Nov 24, 2022
@PeerRich PeerRich deleted the bugfix/apple-calendar-tz-fix branch November 24, 2022 11:07
@PeerRich PeerRich added the core area: core, team members only label Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working core area: core, team members only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CAL-296] iCalendar timezone is off (doubles) CalDAV
3 participants